openshift / openshift-azure

Azure Red Hat Openshift

https://azure.microsoft.com/en-us/services/openshift/

Apache License 2.0

49 stars 51 forks source link

Prep v18 for development #2283

Closed ehashman closed 4 years ago

ehashman commented 4 years ago

NONE

troy0820 commented 4 years ago

/lgtm

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, troy0820

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/openshift-azure/blob/master/OWNERS)~~ [ehashman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov[bot] commented 4 years ago

Codecov Report

Merging #2283 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2283   +/-   ##
=======================================
  Coverage   41.65%   41.65%           
=======================================
  Files         305      305           
  Lines       23802    23802           
=======================================
  Hits         9915     9915           
  Misses      13307    13307           
  Partials      580      580

openshift-bot commented 4 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

ehashman commented 4 years ago

/hold

Need #2284 to merge so verify will pass.

ehashman commented 4 years ago

/cancel hold /retest

ehashman commented 4 years ago

err I think I mean

/hold cancel

openshift-bot commented 4 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 4 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.