openshift / openshift-azure

Azure Red Hat Openshift

https://azure.microsoft.com/en-us/services/openshift/

Apache License 2.0

49 stars 51 forks source link

Revert "HACK: Disable false negatives for now" #2285

Closed ehashman closed 3 years ago

ehashman commented 4 years ago

This reverts commit db88a2ad1701f4c6c3384cd0e926fa39c1ea2d6d.

False negatives are fixed in scap-security-guide-0.1.49-5.el7 See also https://bugzilla.redhat.com/show_bug.cgi?id=1823576

NONE

Fixes #2269.

Need to wait for the right version of the security guide to get published...

/hold

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/openshift-azure/blob/master/OWNERS)~~ [ehashman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov[bot] commented 4 years ago

Codecov Report

Merging #2285 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2285   +/-   ##
=======================================
  Coverage   41.65%   41.65%           
=======================================
  Files         305      305           
  Lines       23802    23802           
=======================================
  Hits         9915     9915           
  Misses      13307    13307           
  Partials      580      580

openshift-ci-robot commented 3 years ago

@ehashman: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
e2e-create-20191027-private	8f6491c47e288bd13d460cf8055530b3cb47a209	link	`/test e2e-create-20191027-private`
upgrade-v18.0	8f6491c47e288bd13d460cf8055530b3cb47a209	link	`/test upgrade-v18.0`
upgrade-v20.0	8f6491c47e288bd13d460cf8055530b3cb47a209	link	`/test upgrade-v20.0`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

openshift-bot commented 3 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 3 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale