openshift / openshift-azure

Azure Red Hat Openshift

https://azure.microsoft.com/en-us/services/openshift/

Apache License 2.0

49 stars 51 forks source link

vendor golang.org/x/net #2290

Closed jim-minter closed 4 years ago

jim-minter commented 4 years ago

bring golang.org/x/net forwards to ab555f366c4508dbe0802550b1b20c46c5c18aa0 to add workaround code for 'http2: no cached connection was available' errors.

resolve "http2: no cached connection was available" error in admission controller

This is basically a rebase to get golang/go#22091 . It is the same as #2289 but without the private cluster fix.

mjudeikis commented 4 years ago

/retest

mjudeikis commented 4 years ago

/retest

codecov[bot] commented 4 years ago

Codecov Report

Merging #2290 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2290   +/-   ##
=======================================
  Coverage   41.66%   41.66%           
=======================================
  Files         305      305           
  Lines       23835    23835           
=======================================
  Hits         9932     9932           
  Misses      13323    13323           
  Partials      580      580

mjudeikis commented 4 years ago

/retest

mjudeikis commented 4 years ago

/retest

mjudeikis commented 4 years ago

/retest

openshift-ci-robot commented 4 years ago

@jim-minter: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
upgrade-v15.0	076dc3ef989201d4ceea399dd5b606414d88a5be	link	`/test upgrade-v15.0`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

mjudeikis commented 4 years ago

/retest /lgtm

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jim-minter, mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/openshift-azure/blob/master/OWNERS)~~ [jim-minter,mjudeikis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ehashman commented 4 years ago

/cherry-pick release-v17

openshift-cherrypick-robot commented 4 years ago

@ehashman: new pull request created: #2293

In response to [this](https://github.com/openshift/openshift-azure/pull/2290#issuecomment-631539896): >/cherry-pick release-v17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.