search

openshift / openshift-azure

Azure Red Hat Openshift
https://azure.microsoft.com/en-us/services/openshift/
Apache License 2.0
49 stars 51 forks source link

[release-v19] Disable SecurityPatchPackages certificate when feature isn't in use #2324

Closed ehashman closed 4 years ago

ehashman commented 4 years ago 
If SecurityPatchPackages is not set, do not validate its corresponding certificate

@jim-minter note that I extremely lazily added a unit test case here because I did not think it was worth doing a refactor.

jim-minter commented 4 years ago

/lgtm

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, jim-minter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/openshift-azure/blob/release-v19/OWNERS)~~ [ehashman,jim-minter] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ehashman commented 4 years ago

/test e2e-scaleupdown

openshift-bot commented 4 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 4 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 4 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.