search

openshift / openshift-controller-manager

Coming soon. Do not import.
Apache License 2.0
25 stars 78 forks source link

OCPBUGS-36833: 4.16 "Bad" reconciliation loops can cause unbounded dockercfg secret creation #319

Closed sanchezl closed 4 months ago

sanchezl commented 4 months ago
openshift-ci-robot commented 4 months ago

@sanchezl: This pull request references Jira Issue OCPBUGS-36833, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/openshift-controller-manager/pull/319): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-controller-manager). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dinhxuanvu commented 4 months ago

/jira refresh

openshift-ci-robot commented 4 months ago

@dinhxuanvu: This pull request references Jira Issue OCPBUGS-36833, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @xingxingxia

In response to [this](https://github.com/openshift/openshift-controller-manager/pull/319#issuecomment-2221709994): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-controller-manager). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, sanchezl, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/openshift-controller-manager/blob/master/OWNERS)~~ [soltysh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dinhxuanvu commented 4 months ago

@sanchezl These changes seem to bump ugly with the hypershift conformance test. The test looks perma-failed.

openshift-ci-robot commented 4 months ago

/retest-required

Remaining retests: 0 against base HEAD dc54a288f78e85e880ee37da2877629efd65c8c6 and 2 for PR HEAD a9519ba0fca28087bb721d6775050eb57fd5e007 in total

openshift-ci[bot] commented 4 months ago

@sanchezl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security a9519ba0fca28087bb721d6775050eb57fd5e007 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 4 months ago

@sanchezl: Jira Issue OCPBUGS-36833: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36833 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/openshift-controller-manager/pull/319): >* The image-registry service account controller attempts to recover a clobbered annotation before deciding to creating a new one. >* The image-registry image pull secret controller cleans up orphaned managed image pulled secrets (deletes the secret and removes references from the service account). Note that references will remain in the service account if the secrets are deleted before applying this patch. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-controller-manager). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sanchezl commented 4 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 4 months ago

@sanchezl: new pull request created: #320

In response to [this](https://github.com/openshift/openshift-controller-manager/pull/319#issuecomment-2222703120): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-openshift-controller-manager-container-v4.17.0-202407111341.p0.g3b88c69.assembly.stream.el9 for distgit ose-openshift-controller-manager. All builds following this will include this PR.