search

openshift / openshift-controller-manager

Coming soon. Do not import.
Apache License 2.0
25 stars 78 forks source link

OCPBUGS-30704: replaces deprecated square/go-jose wtih go-jose/go-jose #327

Closed apoorvajagtap closed 2 months ago

apoorvajagtap commented 3 months ago

This commit replaces all the references of github.com/square/go-jose to github.com/go-jose/go-jose@v2.

openshift-ci-robot commented 3 months ago

@apoorvajagtap: This pull request references Jira Issue OCPBUGS-30704, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/openshift-controller-manager/pull/327): >This commit replaces all the references of [github.com/square/go-jose](https://github.com/square/go-jose) to [github.com/go-jose/go-jose@v2](https://github.com/go-jose/go-jose). Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-controller-manager). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
apoorvajagtap commented 3 months ago

/cherrypick release-4.17 release-4.16

openshift-cherrypick-robot commented 3 months ago

@apoorvajagtap: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/openshift-controller-manager/pull/327#issuecomment-2288496238): >/cherrypick release-4.17 release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
apoorvajagtap commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@apoorvajagtap: This pull request references Jira Issue OCPBUGS-30704, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
In response to [this](https://github.com/openshift/openshift-controller-manager/pull/327#issuecomment-2288497272): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-controller-manager). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ramessesii2 commented 2 months ago

/retest

apoorvajagtap commented 2 months ago

/retest-required

apoorvajagtap commented 2 months ago

/retest

openshift-ci[bot] commented 2 months ago

@apoorvajagtap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security bffeaf35e2a2e89d5bca1ec2c6c894e0de32e6da link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
apoorvajagtap commented 2 months ago

/assign @sayan-biswas

sayan-biswas commented 2 months ago

/approve

sayan-biswas commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apoorvajagtap, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/openshift-controller-manager/blob/master/OWNERS)~~ [sayan-biswas] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

@apoorvajagtap: Jira Issue OCPBUGS-30704: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30704 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/openshift-controller-manager/pull/327): >This commit replaces all the references of [github.com/square/go-jose](https://github.com/square/go-jose) to [github.com/go-jose/go-jose@v2](https://github.com/go-jose/go-jose). Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-controller-manager). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 2 months ago

@apoorvajagtap: new pull request created: #328

In response to [this](https://github.com/openshift/openshift-controller-manager/pull/327#issuecomment-2288496238): >/cherrypick release-4.17 release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-openshift-controller-manager This PR has been included in build ose-openshift-controller-manager-container-v4.18.0-202408290912.p0.gc932427.assembly.stream.el9. All builds following this will include this PR.