openshift / openshift-controller-manager

Coming soon. Do not import.
Apache License 2.0
25 stars 78 forks source link

OCPBUGS-32871: replaces deprecated square/go-jose wtih go-jose/go-jose #332

Closed apoorvajagtap closed 2 months ago

apoorvajagtap commented 2 months ago

This commit replaces all the references of github.com/square/go-jose to github.com/go-jose/go-jose@v2.

openshift-ci-robot commented 2 months ago

@apoorvajagtap: This pull request references Jira Issue OCPBUGS-32871, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/openshift-controller-manager/pull/332): >This commit replaces all the references of [github.com/square/go-jose](https://github.com/square/go-jose) to [github.com/go-jose/go-jose@v2](https://github.com/go-jose/go-jose). Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-controller-manager). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-merge-robot commented 2 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 2 months ago

@apoorvajagtap: This pull request references Jira Issue OCPBUGS-32871. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to [this](https://github.com/openshift/openshift-controller-manager/pull/332): >This commit replaces all the references of [github.com/square/go-jose](https://github.com/square/go-jose) to [github.com/go-jose/go-jose@v2](https://github.com/go-jose/go-jose). Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-controller-manager). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

@apoorvajagtap: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security fd507700090b57dfffabe0abb472c58c2f4918d0 link false /test security
ci/prow/e2e-gcp-ovn fd507700090b57dfffabe0abb472c58c2f4918d0 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn fd507700090b57dfffabe0abb472c58c2f4918d0 link true /test e2e-aws-ovn
ci/prow/images fd507700090b57dfffabe0abb472c58c2f4918d0 link true /test images
ci/prow/e2e-gcp-ovn-builds fd507700090b57dfffabe0abb472c58c2f4918d0 link true /test e2e-gcp-ovn-builds
ci/prow/e2e-hypershift-conformance fd507700090b57dfffabe0abb472c58c2f4918d0 link true /test e2e-hypershift-conformance
ci/prow/openshift-e2e-aws-ovn-builds-techpreview fd507700090b57dfffabe0abb472c58c2f4918d0 link false /test openshift-e2e-aws-ovn-builds-techpreview
ci/prow/e2e-aws-ovn-proxy fd507700090b57dfffabe0abb472c58c2f4918d0 link false /test e2e-aws-ovn-proxy
ci/prow/e2e-aws-ovn-upgrade fd507700090b57dfffabe0abb472c58c2f4918d0 link true /test e2e-aws-ovn-upgrade
ci/prow/verify fd507700090b57dfffabe0abb472c58c2f4918d0 link true /test verify
ci/prow/unit fd507700090b57dfffabe0abb472c58c2f4918d0 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: apoorvajagtap Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/openshift-controller-manager/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment