search

openshift / openshift-controller-manager

Coming soon. Do not import.
Apache License 2.0
25 stars 78 forks source link

OCPBUGS-42097: user system:serviceaccount:openshift-infra:serviceaccount-pull-secrets-controller in ns/openshift-infra must not produce too many applies #337

Closed sanchezl closed 4 weeks ago

sanchezl commented 1 month ago

An Apply request was being made unnecessarily against secrets that did not require any updates.

openshift-ci-robot commented 1 month ago

@sanchezl: This pull request references Jira Issue OCPBUGS-42097, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @jitendar-singh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/openshift-controller-manager/pull/337): >An Apply request was being made unnecessarily against secrets that did not require any updates. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-controller-manager). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sanchezl commented 1 month ago

/retest

sanchezl commented 1 month ago

/retest

sanchezl commented 1 month ago

/override ci/prow/e2e-gcp-ovn-builds

/override ci/prow/openshift-e2e-aws-ovn-builds-techpreview

Known issue related to ruby imagestream bump: https://issues.redhat.com/browse/OCPBUGS-42237

openshift-ci[bot] commented 1 month ago

@sanchezl: sanchezl unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to [this](https://github.com/openshift/openshift-controller-manager/pull/337#issuecomment-2374108442): >/override ci/prow/e2e-gcp-ovn-builds > >/override ci/prow/openshift-e2e-aws-ovn-builds-techpreview > >Known issue related to ruby imagestream bump: https://issues.redhat.com/browse/OCPBUGS-42237 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sanchezl commented 1 month ago

/retest

sanchezl commented 1 month ago

/retest

benluddy commented 1 month ago

This looks right to me. I'm assuming there is reasonable existing test coverage and that we've observed the expected reduction in applies somewhere (placing a hold in case you're still checking this for the latest revision).

/lgtm /hold

sanchezl commented 1 month ago

Requires https://github.com/openshift/origin/pull/29134

sanchezl commented 1 month ago

/retest-required

sanchezl commented 1 month ago

/hold cancel

sanchezl commented 1 month ago

/retest-required

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: benluddy, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/openshift-controller-manager/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
deads2k commented 1 month ago

/override ci/prow/security

openshift-ci[bot] commented 1 month ago

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/security

In response to [this](https://github.com/openshift/openshift-controller-manager/pull/337#issuecomment-2400787990): >/override ci/prow/security Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 979e5c9866d7a674a1cf845b0c84707f7af76616 and 2 for PR HEAD 03556ab138009a5a95e5c0b4285cd8358ea3d22c in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 979e5c9866d7a674a1cf845b0c84707f7af76616 and 2 for PR HEAD 03556ab138009a5a95e5c0b4285cd8358ea3d22c in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 979e5c9866d7a674a1cf845b0c84707f7af76616 and 2 for PR HEAD 03556ab138009a5a95e5c0b4285cd8358ea3d22c in total

flavianmissi commented 1 month ago

I'm not that familiar with this code but as far as I can see everything looks solid, thanks for doing this @sanchezl 🙏🏼

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 979e5c9866d7a674a1cf845b0c84707f7af76616 and 2 for PR HEAD 03556ab138009a5a95e5c0b4285cd8358ea3d22c in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 979e5c9866d7a674a1cf845b0c84707f7af76616 and 2 for PR HEAD 03556ab138009a5a95e5c0b4285cd8358ea3d22c in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 979e5c9866d7a674a1cf845b0c84707f7af76616 and 2 for PR HEAD 03556ab138009a5a95e5c0b4285cd8358ea3d22c in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 979e5c9866d7a674a1cf845b0c84707f7af76616 and 2 for PR HEAD 03556ab138009a5a95e5c0b4285cd8358ea3d22c in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 979e5c9866d7a674a1cf845b0c84707f7af76616 and 2 for PR HEAD 03556ab138009a5a95e5c0b4285cd8358ea3d22c in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 979e5c9866d7a674a1cf845b0c84707f7af76616 and 2 for PR HEAD 03556ab138009a5a95e5c0b4285cd8358ea3d22c in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 979e5c9866d7a674a1cf845b0c84707f7af76616 and 2 for PR HEAD 03556ab138009a5a95e5c0b4285cd8358ea3d22c in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 979e5c9866d7a674a1cf845b0c84707f7af76616 and 2 for PR HEAD 03556ab138009a5a95e5c0b4285cd8358ea3d22c in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 979e5c9866d7a674a1cf845b0c84707f7af76616 and 2 for PR HEAD 03556ab138009a5a95e5c0b4285cd8358ea3d22c in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 979e5c9866d7a674a1cf845b0c84707f7af76616 and 2 for PR HEAD 03556ab138009a5a95e5c0b4285cd8358ea3d22c in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 979e5c9866d7a674a1cf845b0c84707f7af76616 and 2 for PR HEAD 03556ab138009a5a95e5c0b4285cd8358ea3d22c in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 979e5c9866d7a674a1cf845b0c84707f7af76616 and 2 for PR HEAD 03556ab138009a5a95e5c0b4285cd8358ea3d22c in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 528c32ccf4f82560716b34110b8ebdab2acafab8 and 1 for PR HEAD 03556ab138009a5a95e5c0b4285cd8358ea3d22c in total

openshift-ci-robot commented 4 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 528c32ccf4f82560716b34110b8ebdab2acafab8 and 2 for PR HEAD 03556ab138009a5a95e5c0b4285cd8358ea3d22c in total

sanchezl commented 4 weeks ago

/retest

deads2k commented 4 weeks ago

no response on slack, doesn't look related. yolo

/override ci/prow/e2e-hypershift-conformance

cc @sjenning

openshift-ci[bot] commented 4 weeks ago

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-hypershift-conformance

In response to [this](https://github.com/openshift/openshift-controller-manager/pull/337#issuecomment-2412474598): >no response on slack, doesn't look related. yolo > >/override ci/prow/e2e-hypershift-conformance > >cc @sjenning Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 4 weeks ago

@sanchezl: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 4 weeks ago

@sanchezl: Jira Issue OCPBUGS-42097: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42097 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/openshift-controller-manager/pull/337): >An Apply request was being made unnecessarily against secrets that did not require any updates. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-controller-manager). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 4 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-openshift-controller-manager This PR has been included in build ose-openshift-controller-manager-container-v4.18.0-202410150410.p0.g0d8ef02.assembly.stream.el9. All builds following this will include this PR.

sanchezl commented 1 week ago

/cherry-pick release-4.17 release-4.16

openshift-cherrypick-robot commented 1 week ago

@sanchezl: new pull request created: #350

In response to [this](https://github.com/openshift/openshift-controller-manager/pull/337#issuecomment-2451138005): >/cherry-pick release-4.17 release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.