search

openshift / openshift-docs

OpenShift 3 and 4 product and community documentation
https://docs.openshift.com
Apache License 2.0
748 stars 1.74k forks source link

[enterprise-4.2] Edit suggested in file installing/installing_bare_metal/installing-bare-metal.adoc #17679

Closed amelie1979 closed 3 years ago

amelie1979 commented 4 years ago

Which section(s) is the issue in?

https://docs.openshift.com/container-platform/4.2/installing/installing_bare_metal/installing-bare-metal.html#installation-bare-metal-config-yaml_installing-bare-metal

What needs fixing?

install-config.yaml example should include all possible configuration such as : networking.machineCIDR or add a link to a full possible configuration install-config.yaml.

jboxman commented 4 years ago

@amelie1979, machineCIDR is used for installer provisioned infrastructure; I don't think it is used at all for user provisioned infrastructure, so that's why it's absent from the install-config.yaml.

amelie1979 commented 4 years ago

@jboxman there is a reference to it in the proxy setting section in the official documentation, also if this value is not present; the no_proxy inherited from the default value. Then the proxy value are not containing the node subnet, but the default hardcode 10.0.0.0/16 value. https://docs.openshift.com/container-platform/4.2/installing/installing_bare_metal/installing-bare-metal.html#installation-configure-proxy_installing-bare-metal See code for : defaultMachineCIDR https://github.com/openshift/installer/blob/release-4.2/pkg/types/defaults/installconfig.go

It is also document as customization (doc user) https://github.com/openshift/installer/blob/release-4.2/docs/user/customization.md#custom-networking

openshift-bot commented 4 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 3 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 3 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot commented 3 years ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/openshift-docs/issues/17679#issuecomment-731496170): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.