search

openshift / openshift-docs

OpenShift 3 and 4 product and community documentation
https://docs.openshift.com
Apache License 2.0
745 stars 1.72k forks source link

[enterprise-4.5] Edit suggested in file installing/installing_azure/installing-azure-user-infra.adoc #22901

Closed mgahagan73 closed 3 years ago

mgahagan73 commented 4 years ago

Which section(s) is the issue in?

Step 4 under: https://docs.openshift.com/container-platform/4.5/installing/installing_azure/installing-azure-user-infra.html#installation-user-infra-generate-k8s-manifest-ignition_installing-azure-user-infra

What needs fixing?

The entirety of step 4 may be removed because it is no longer necessary in 4.5. The edit to manifests/cluster-scheduler-02-config.yml already has mastersSchedulable set to False

mgahagan73 commented 4 years ago

After speaking with some members of the OSD dev team, it appears that this was left over from instructions in the 4.3 timeframe where the user was directed to set compute.replicas to 0 in the install-config.yaml and setting compute.replicas to 0 caused the installer to output the template with mastersSchedulable to True. We no longer instruct users to do this starting with 4.4. Unfortunately I do not have enough experience with the other cloud providers to determine if any changes are needed there.

openshift-bot commented 3 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 3 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 3 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot commented 3 years ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/openshift-docs/issues/22901#issuecomment-748757876): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.