openshift / openshift-docs

OpenShift 3 and 4 product and community documentation
https://docs.openshift.com
Apache License 2.0
764 stars 1.76k forks source link

[enterprise-4.10] Issue in file scalability_and_performance/ztp-deploying-disconnected.adoc #50050

Closed joaquinfll closed 2 years ago

joaquinfll commented 2 years ago

Which section(s) is the issue in?

Adding RHCOS ISO and RootFS images to the disconnected mirror host. This also happens for version 4.11.

What needs fixing?

The step "b. Download the required images:" is pointing to pre-release images in "https://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/pre-release/"

I think this should reference the final release in "https://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/4.10/latest/"

kelbrown20 commented 2 years ago

/assign kelbrown20

kelbrown20 commented 2 years ago

Updates documentation: 4.10 - https://docs.openshift.com/container-platform/4.10/scalability_and_performance/ztp-deploying-disconnected.html#ztp-acm-adding-images-to-mirror-registry_ztp-deploying-disconnected 4.11 - https://docs.openshift.com/container-platform/4.11/scalability_and_performance/ztp-deploying-disconnected.html#ztp-acm-adding-images-to-mirror-registry_ztp-deploying-disconnected

Setting to close

kelbrown20 commented 2 years ago

/close

openshift-ci[bot] commented 2 years ago

@kelbrown20: Closing this issue.

In response to [this](https://github.com/openshift/openshift-docs/issues/50050#issuecomment-1252459670): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joaquinfll commented 2 years ago

@kelbrown20 the links in the section: The step "b. Download the required images:" is pointing to pre-release images in "https://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/pre-release/"

Still points to the pre-release.

I can see you fixed the link in the section before that is also nice.

kelbrown20 commented 2 years ago

@joaquinfll My apologies, that was my mistake. Thank you for pointing that out! Will make new PRs to fix the issue. Can you PTAL at the new linked PR and confirm the changes? Leaving out the specific versions becuase the user will add ${OCP_VERSION} when running the command

kelbrown20 commented 1 year ago

Fix updated in PR #49805