search

openshift / openshift-docs

OpenShift 3 and 4 product and community documentation
https://docs.openshift.com
Apache License 2.0
764 stars 1.76k forks source link

[enterprise-4.11] Issue in file scalability_and_performance/routing-optimization.adoc #51823

Closed swathan closed 1 year ago

swathan commented 2 years ago

Which section(s) is the issue in?

Ingress Controller (router) performance optimizations

What needs fixing?

In the document it is mentioned that it is not supported to modify the environment variables directly by modifying the deployment of Ingress POD.

Whereas in this section of the document, it is mentioned that we can modify the environment variables by modifying the IngressController directly.

Somewhere the explanation of the document Ingress Controller (router) performance optimizations is misleading for the users.

Most of the users will think that OpenShift won't support tuning ROUTER_THREADS, ROUTER_DEFAULT_TUNNEL_TIMEOUT, ROUTER_DEFAULT_CLIENT_TIMEOUT, ROUTER_DEFAULT_SERVER_TIMEOUT, and RELOAD_INTERVAL. But in fact, they can tune them with tuningOptions.

Thus the expectation from this issue is that the section Ingress Controller (router) performance optimizations of the Optimizing Routing document should highlight that changing the underlying timeouts variables is supported through the tuningOptions to avoid the confusion.

swathan commented 1 year ago

PR is merged for this issue: https://github.com/openshift/openshift-docs/pull/52998

openshift-bot commented 1 year ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 1 year ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 1 year ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 1 year ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/openshift-docs/issues/51823#issuecomment-1585293247): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.