openshift / openshift-docs

OpenShift 3 and 4 product and community documentation
https://docs.openshift.com
Apache License 2.0
748 stars 1.74k forks source link

HAProxy router option persist #52922

Open thomaswoeckinger opened 1 year ago

thomaswoeckinger commented 1 year ago

Which section(s) is the issue in?

Modules, Network route specific annotations

What needs fixing?

Documentation for option persist added by pull request https://github.com/openshift/router/pull/420

openshift-bot commented 1 year ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 1 year ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 1 year ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 1 year ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/openshift-docs/issues/52922#issuecomment-1512253440): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
thomaswoeckinger commented 1 year ago

/remove-lifecycle rotten

thomaswoeckinger commented 1 year ago

/lifecycle frozen

thomaswoeckinger commented 1 year ago

/reopen

openshift-ci[bot] commented 1 year ago

@thomaswoeckinger: Reopened this issue.

In response to [this](https://github.com/openshift/openshift-docs/issues/52922#issuecomment-1519067669): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ahardin-rh commented 7 months ago

Our documentation team cannot document this as an option until the code itself is merged. It looks like https://github.com/openshift/router/pull/420 was closed due to some issues getting this through the RFE process.

@candita @frobware @Miciah Can you please revisit this and help this through the RFE process?

candita commented 7 months ago

@ahardin-rh the issue went rotten, and the code wasn't merged so the docs don't need to be merged. As far as I can tell, this PR can be closed as well.