openshift / openshift-docs

OpenShift 3 and 4 product and community documentation
https://docs.openshift.com
Apache License 2.0
738 stars 1.7k forks source link

Update ocp-4-15-release-notes, since there is no plan to remove icsp in future release. #78465

Open bshaw7 opened 2 days ago

bshaw7 commented 2 days ago

SInce there is no plan to remove ICSP object hence we need to update the release notes accordingly.

From this: Using an ICSP object to configure repository mirroring is a deprecated feature. Deprecated functionality is still included in OpenShift Container Platform and continues to be supported; however, it will be removed in a future release of this product and is not recommended for new deployments.

To this: Using an ICSP object to configure repository mirroring is a deprecated feature. Deprecated functionality is still included in OpenShift Container Platform and continues to be supported; however, It might be removed in a future release of this product. Because it is deprecated functionality, avoid using it for new deployments.

Version(s): 4.13, 4.14, 4.15

Issue: https://issues.redhat.com/browse/OCPBUGS-36519

Link to docs preview: https://docs.redhat.com/en/documentation/openshift_container_platform/4.15/html/release_notes/ocp-4-15-release-notes#ocp-4-15-nodes-icsp-idms-compatibility

OpenShift Container Platform 4.15 release notes > 1.3. New features and enhancements > 1.3.17. Nodes > 1.3.17.3. ICSP, IDMS, and ITMS are now compatible

QE review:

bshaw7 commented 2 days ago

/label peer-review-needed

ocpdocs-previewbot commented 2 days ago

šŸ¤– Thu Jul 04 12:28:57 - Prow CI generated the docs preview:

https://78465--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-15-release-notes.html

kalexand-rh commented 2 days ago

@mburke5678, will you please get this issue validated and through CM?

bshaw7 commented 2 days ago

Hello @gauravsingh85 , Can you help with the validation on this PR to @mburke5678 and @kalexand-rh

zaneb commented 2 days ago

The future is long, we should not commit to this.

bshaw7 commented 2 days ago

hey @zaneb now the statement is - "it may be removed in a future release of this product and is not recommended for new deployments" Can you review once.

zaneb commented 2 days ago

I'm OK with this. Note that we explicitly document this as a Tier 1 API, meaning that we have committed not to removing it within a major release. So if you want to be more specific you can say that.

Srivaralakshmi commented 1 day ago

@bshaw7 Are you sure you want this PR to be CP-ed only in 4.13, 4.14, and 4.15? Not to later versions? Please clarify. TY!

bshaw7 commented 1 day ago

@Srivaralakshmi Yes only for 4.13, 4.14, and 4.15. It's not mention in 4.16 release notes.

bshaw7 commented 1 day ago

@Srivaralakshmi we should go with below only. Instead of saying 'Do not use'

Using an ICSP object to configure repository mirroring is a deprecated feature. Deprecated functionality is still included in {product-title} and continues to be supported. However, it might be removed in a future release of this product. It is not recommended to use deprecated functionality for new deployments.

bshaw7 commented 1 day ago

@Srivaralakshmi updated as per suggestion.

bshaw7 commented 1 day ago

/label merge-review-needed

openshift-ci[bot] commented 1 day ago

@bshaw7: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
mburke5678 commented 1 day ago

@gauravsingh85 @nee1esh @control-d @rphillips @arnaik-rh PTAL

opayne1 commented 20 hours ago

Looks like we need a few more acks before we can merge. I see @mburke5678 has tagged them. I am removing the merge review needed label for now.

gauravsingh85 commented 14 hours ago

LGTM