Open bshaw7 opened 2 days ago
/label peer-review-needed
š¤ Thu Jul 04 12:28:57 - Prow CI generated the docs preview:
@mburke5678, will you please get this issue validated and through CM?
Hello @gauravsingh85 , Can you help with the validation on this PR to @mburke5678 and @kalexand-rh
The future is long, we should not commit to this.
hey @zaneb now the statement is - "it may be removed in a future release of this product and is not recommended for new deployments" Can you review once.
I'm OK with this. Note that we explicitly document this as a Tier 1 API, meaning that we have committed not to removing it within a major release. So if you want to be more specific you can say that.
@bshaw7 Are you sure you want this PR to be CP-ed only in 4.13, 4.14, and 4.15? Not to later versions? Please clarify. TY!
@Srivaralakshmi Yes only for 4.13, 4.14, and 4.15. It's not mention in 4.16 release notes.
@Srivaralakshmi we should go with below only. Instead of saying 'Do not use'
Using an ICSP object to configure repository mirroring is a deprecated feature. Deprecated functionality is still included in {product-title} and continues to be supported. However, it might be removed in a future release of this product. It is not recommended to use deprecated functionality for new deployments.
@Srivaralakshmi updated as per suggestion.
/label merge-review-needed
@bshaw7: all tests passed!
Full PR test history. Your PR dashboard.
@gauravsingh85 @nee1esh @control-d @rphillips @arnaik-rh PTAL
Looks like we need a few more acks before we can merge. I see @mburke5678 has tagged them. I am removing the merge review needed label for now.
LGTM
SInce there is no plan to remove ICSP object hence we need to update the release notes accordingly.
From this: Using an ICSP object to configure repository mirroring is a deprecated feature. Deprecated functionality is still included in OpenShift Container Platform and continues to be supported; however, it will be removed in a future release of this product and is not recommended for new deployments.
To this: Using an ICSP object to configure repository mirroring is a deprecated feature. Deprecated functionality is still included in OpenShift Container Platform and continues to be supported; however, It might be removed in a future release of this product. Because it is deprecated functionality, avoid using it for new deployments.
Version(s): 4.13, 4.14, 4.15
Issue: https://issues.redhat.com/browse/OCPBUGS-36519
Link to docs preview: https://docs.redhat.com/en/documentation/openshift_container_platform/4.15/html/release_notes/ocp-4-15-release-notes#ocp-4-15-nodes-icsp-idms-compatibility
OpenShift Container Platform 4.15 release notes > 1.3. New features and enhancements > 1.3.17. Nodes > 1.3.17.3. ICSP, IDMS, and ITMS are now compatible
QE review: