search

openshift / openshift-restclient-java

Other
78 stars 112 forks source link

Refactor: Refactoring code #480

Closed Saumya-09 closed 1 year ago

Saumya-09 commented 1 year ago
  1. GetEnvSuper.java : Both the interfaces ISourceBuildStrategy and IJenkinsPipelineStrategy had the same method getEnvVars(), so I created a new interface and implemented that directly where getEnvVars() was used.
  2. SourceBuilderStrategy.java : Renamed the variable to avoide confusion with reserved keyword "var".
  3. SourceBuilderStrategy.java and JenkinsPipelineStrategy : Both the method had exactly same method implementaion, so created a new class with the method that can be reused.
  4. ApiTypeMapper : Decomposed the condition to make it more readable and maintainable.
  5. ServiceAccount.java : Two methods had exactly same implementation so extracted the method to avoide duplication of code.
adietish commented 1 year ago

@Saumya-09 Thanks for your contribution. But this client isn't maintained any longer. Please consider moving to the newer and actively developed https://github.com/fabric8io/kubernetes-client which includes an openshift-client, too.

openshift-bot commented 1 year ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 1 year ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 1 year ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 1 year ago

@openshift-bot: Closed this PR.

In response to [this](https://github.com/openshift/openshift-restclient-java/pull/480#issuecomment-1712665334): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.