Closed pravisankar closed 9 years ago
Why is it necessary to return a pointer to a slice, given that a slice is a reference type (i.e. the cost to copy is negligible)?
Agree, Copy cost is not worth optimizing here but I do prefer Get/Watch API methods on nodes/namespaces/subnets/net-namespaces to be consistent.
Is there a reason not to fix the other methods instead?
Yes, that will be better..thanks. I'll update the PR.
Updated. GetNodes() interface is fixed as part of this PR: https://github.com/openshift/openshift-sdn/pull/133
LGTM
LGTM
@rajatchopra @danwinship PTAL