search

openshift / openshift-sdn

Apache License 2.0
69 stars 63 forks source link

Make Get/Watch interfaces for nodes/subnets/namespaces consistent #136

Closed pravisankar closed 9 years ago

pravisankar commented 9 years ago

@rajatchopra @danwinship PTAL

marun commented 9 years ago

Why is it necessary to return a pointer to a slice, given that a slice is a reference type (i.e. the cost to copy is negligible)?

pravisankar commented 9 years ago

Agree, Copy cost is not worth optimizing here but I do prefer Get/Watch API methods on nodes/namespaces/subnets/net-namespaces to be consistent.

marun commented 9 years ago

Is there a reason not to fix the other methods instead?

pravisankar commented 9 years ago

Yes, that will be better..thanks. I'll update the PR.

pravisankar commented 9 years ago

Updated. GetNodes() interface is fixed as part of this PR: https://github.com/openshift/openshift-sdn/pull/133

danwinship commented 9 years ago

LGTM

dcbw commented 9 years ago

LGTM