search

openshift / openshift-sdn

Apache License 2.0
69 stars 63 forks source link

For multitenant plugin, handle both existing and admin namespaces #138

Closed pravisankar closed 9 years ago

pravisankar commented 9 years ago

closes: #129

pravisankar commented 9 years ago

@rajatchopra PTAL

pravisankar commented 9 years ago

Yes, we should release allocated NetID when writing to etcd fails. This is what happens, when I do copy+paste :) Actually, I should make oc.AdminNamespaces instead of oc.adminNamespaces. Intention here is openshift master will have config param that tells which all namespaces should be treated as special/admin namespaces. If the config param is not explicitly set, it will default to ["default"].

pravisankar commented 9 years ago

Removing WIP, tested these changes on multi-node vagrant setup. @rajatchopra @danwinship updated, PTAL

rajatchopra commented 9 years ago

Where is the default? Plan to set in origin/osdn code?

pravisankar commented 9 years ago

Yes, default is set in origin sdn plugin: https://github.com/openshift/origin/pull/4370