Closed pravisankar closed 9 years ago
@rajatchopra PTAL
Yes, we should release allocated NetID when writing to etcd fails. This is what happens, when I do copy+paste :) Actually, I should make oc.AdminNamespaces instead of oc.adminNamespaces. Intention here is openshift master will have config param that tells which all namespaces should be treated as special/admin namespaces. If the config param is not explicitly set, it will default to ["default"].
Removing WIP, tested these changes on multi-node vagrant setup. @rajatchopra @danwinship updated, PTAL
Where is the default? Plan to set in origin/osdn code?
Yes, default is set in origin sdn plugin: https://github.com/openshift/origin/pull/4370
closes: #129