search

openshift / openshift-sdn

Apache License 2.0
69 stars 63 forks source link

Make "default" an admin namespace #155

Closed danwinship closed 9 years ago

danwinship commented 9 years ago

Not sure at what point this got broken since I'm pretty sure it used to work, but anyway, we're currently not actually using VNID 0 for namespace "default", so it doesn't work...

danwinship commented 9 years ago

@rajatchopra @pravisankar

pravisankar commented 9 years ago

We decided not to merge https://github.com/openshift/origin/pull/4370 and that caused this issue. It will be good, if we let the plugins to decide the sane defaults for AdminNamespaces. Instead of assigning 'default' namespace in ovssubnet/common.go, do it in multitenant.go (https://github.com/openshift/origin/pull/4370/files#diff-d8a8179e40bbd42ad8c40b0fb54e2b4eR36) kc.AdminNamespaces = append(kc.AdminNamespaces, "default") before calling kc.StartMaster(...)

danwinship commented 9 years ago

ok, so this would be an origin change then