search

openshift / openshift-sdn

Apache License 2.0
69 stars 63 forks source link

Use iptables -w flag #173

Closed danwinship closed 9 years ago

danwinship commented 9 years ago

To avoid problems with iptables locking, we need to use the -w flag, if available. Kubernetes's pkg/util/iptables has code to check for its availability and use it if so, so the simplest fix is to just switch to using that.

(Closes https://bugzilla.redhat.com/show_bug.cgi?id=1267670)

dcbw commented 9 years ago

LGTM

sdodson commented 9 years ago

How likely is this to be a problem without this fix? We may pull this into OSE, I know we've had a few reports of this. On Oct 2, 2015 5:32 PM, "Dan Williams" notifications@github.com wrote:

LGTM

— Reply to this email directly or view it on GitHub https://github.com/openshift/openshift-sdn/pull/173#issuecomment-145160098 .

danwinship commented 9 years ago

How likely is this to be a problem without this fix? We may pull this into OSE, I know we've had a few reports of this.

openshift restarts docker as part of its own startup, and both openshift/kubernetes and docker fiddle with iptables rules at startup. So it's a race condition but it will definitely happen now and then.