Validate cluster/service network only when there is a config change

openshift / openshift-sdn

Apache License 2.0

69 stars 63 forks source link

Validate cluster/service network only when there is a config change #267

Closed pravisankar closed 8 years ago

pravisankar commented 8 years ago

@openshift/networking PTAL

danwinship commented 8 years ago

LGTM. This is just an efficiency thing, right? There's nothing actually buggy about the existing code?

dcbw commented 8 years ago

LGTM to me too; same question as danw though....

pravisankar commented 8 years ago

@danwinship @dcbw No issues with the existing code. With this change, validateNetworkConfig() is only called in case of cluster network change and is skipped during start/restart of openshift-master service.