search

openshift / openshift-sdn

Apache License 2.0
69 stars 63 forks source link

Split proxy endpoint filtering out into separate object #300

Closed dcbw closed 8 years ago

dcbw commented 8 years ago

With more origin code this should give us the ability to run the proxy in a separate process.

I chose to keep the registry since the proxy also needs the origin client to get the ClusterNetwork, but I could split that out and simplify things a but further if anyone wants?

dcbw commented 8 years ago

origin side is https://github.com/openshift/origin/pull/8627

danwinship commented 8 years ago

Will need to be rebased on top of #289 (particularly the commit "Simplify Watch resource in SDN")

dcbw commented 8 years ago

@pravisankar changed the name

danwinship commented 8 years ago

You merged your fixes into the wrong commit. Also, I think you missed Ravi's request to have NewMasterPlugin() and NewNodePlugin() both call a private method rather than having NewMasterPlugin() calling NewNodePlugin() (which, admittedly, was a lame suggestion on my part :)

dcbw commented 8 years ago

@danwinship right on all counts; fixed now.

danwinship commented 8 years ago

LGTM

dcbw commented 8 years ago

@pravisankar @rajatchopra

pravisankar commented 8 years ago

minor nit, LGTM

dcbw commented 8 years ago

@pravisankar nit fixed