search

openshift / openshift-sdn

Apache License 2.0
69 stars 63 forks source link

Fix function comments based on best practices from Effective Go #338

Closed CodeLingoTeam closed 5 years ago

CodeLingoTeam commented 5 years ago

Hi, we updated some exported function comments based on best practices from Effective Go. It’s admittedly a relatively minor fix up. Does this help you?

openshift-ci-robot commented 5 years ago

Hi @CodeLingoTeam. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
danwinship commented 5 years ago

This repo is no longer used