search

openshift / openshift-velero-plugin

General Velero plugin for backup and restore of openshift workloads.
Apache License 2.0
47 stars 37 forks source link

logrusr@v1.0.0 causes `go vet ./...` failure #146

Closed kaovilai closed 1 year ago

kaovilai commented 2 years ago 
go vet ./...                                                                               
# github.com/bombsimon/logrusr
../../go/pkg/mod/github.com/bombsimon/logrusr@v1.0.0/logrusr.go:34:9: cannot use &logrusr{…} (value of type *logrusr) as type logr.Logger in return statement
../../go/pkg/mod/github.com/bombsimon/logrusr@v1.0.0/logrusr.go:69:37: undefined: logr.InfoLogger
../../go/pkg/mod/github.com/bombsimon/logrusr@v1.0.0/logrusr.go:84:9: cannot use l (variable of type *logrusr) as type logr.Logger in return statement
../../go/pkg/mod/github.com/bombsimon/logrusr@v1.0.0/logrusr.go:96:9: cannot use l (variable of type *logrusr) as type logr.Logger in return statement
kaovilai commented 2 years ago 
❯ go env      
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/tiger/Library/Caches/go-build"
GOENV="/Users/tiger/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/tiger/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/tiger/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.18.2"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/tiger/git/openshift-velero-plugin/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/62/wkysd_4n0w57ljl9ycfsd9cc0000gn/T/go-build3009178544=/tmp/go-build -gno-record-gcc-switches -fno-common"
openshift-bot commented 1 year ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kaovilai commented 1 year ago

fixed via https://github.com/openshift/openshift-velero-plugin/pull/145