openshift / openshift-velero-plugin

General Velero plugin for backup and restore of openshift workloads.
Apache License 2.0
47 stars 37 forks source link

OADP-1281 Add check for pod with PVB using DefaultVolumesToFsBackup #173

Closed kaovilai closed 1 year ago

kaovilai commented 1 year ago

In OADP 1.2, Velero spec field to default pod volume backups to restic/kopia have changed.

This PR accounts for the new field when deciding whether or not to skip restoring pod with ownerReferences.

Test image ghcr.io/kaovilai/openshift-velero-plugin:accountForFsBackup

additonal effects:

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/openshift-velero-plugin/blob/master/OWNERS)~~ [kaovilai,sseago] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kaovilai commented 1 year ago

/test unit-test

openshift-ci[bot] commented 1 year ago

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
hhpatel14 commented 1 year ago

/lgtm