Imagestream secret handling improvement/cleanup

[kaovilai]

This PR was tested against a GCP WIF cluster. It is not needed for GCP WIF to work but provides general cleanup and minor fixes for the overall imagestream code.

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Test Image

spec:
  unsupportedOverrides:
    openshiftPluginImageFqin: 'ghcr.io/kaovilai/openshift-velero-plugin:wif'

[openshift-ci[bot]]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

[kaovilai]

Upon testing quay image of openshift-velero-plugin:latest prior to this change, it seems GCP WIF with Imagestream backup is already working 🤷 so reducing changes here to minor improvements to bsl credential path generation.

[openshift-ci[bot]]

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[kaovilai]

/cc @shubham-pampattiwar @mateusoliveira43 @sseago @mpryc

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/openshift-velero-plugin/blob/master/OWNERS)~~ [kaovilai,shubham-pampattiwar,sseago] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[shubham-pampattiwar]

/lgtm

[kaovilai]

/cherry-pick oadp-1.3

[openshift-cherrypick-robot]

@kaovilai: new pull request could not be created: failed to create pull request against openshift/openshift-velero-plugin#oadp-1.3 from head openshift-cherrypick-robot:cherry-pick-207-to-oadp-1.3: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:oadp-1.3 and openshift-cherrypick-robot:cherry-pick-207-to-oadp-1.3"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to [this](https://github.com/openshift/openshift-velero-plugin/pull/207#issuecomment-1830474948): >/cherry-pick oadp-1.3 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.