search

openshift / openshift-velero-plugin

General Velero plugin for backup and restore of openshift workloads.
Apache License 2.0
48 stars 38 forks source link

OADP-3051: Always restore replicaset #232

Closed sseago closed 6 months ago

sseago commented 6 months ago

Always restore replicaset since in some cross-cluster restore scenarios a newly-deployed replicaset will get a different name, breaking the restored pod.

Also, remove MTC-specific RS backup plugin, since the only action there was to mark paused replicasets for restore, which is unnecessary now that we're restoring all of them.

openshift-ci-robot commented 6 months ago

@sseago: This pull request references OADP-3051 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/openshift-velero-plugin/pull/232): >Always restore replicaset since in some cross-cluster restore scenarios a newly-deployed replicaset will get a different name, breaking the restored pod. > >Also, remove MTC-specific RS backup plugin, since the only action there was to mark paused replicasets for restore, which is unnecessary now that we're restoring all of them. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-velero-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 months ago

@sseago: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sseago commented 6 months ago

/cherry-pick oadp-1.3

openshift-cherrypick-robot commented 6 months ago

@sseago: once the present PR merges, I will cherry-pick it on top of oadp-1.3 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/openshift-velero-plugin/pull/232#issuecomment-1995494855): >/cherry-pick oadp-1.3 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
shubham-pampattiwar commented 6 months ago

/lgtm

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpryc, shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/openshift-velero-plugin/blob/master/OWNERS)~~ [shubham-pampattiwar,sseago] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 6 months ago

@sseago: new pull request created: #234

In response to [this](https://github.com/openshift/openshift-velero-plugin/pull/232#issuecomment-1995494855): >/cherry-pick oadp-1.3 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.