Closed shubham-pampattiwar closed 3 months ago
@shubham-pampattiwar: This pull request references OADP-3598 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
Testing on OCP 4.14.z with registry enabled:
Defaulted container "velero" out of: velero, openshift-velero-plugin (init), velero-plugin-for-aws (init), velero-plugin-for-csi (init)
time="2024-03-15T16:12:52Z" level=info msg="shubham imageRegistryEnabled: true" cmd=/plugins/velero-plugins logSource="/opt/app-root/src/github.com/konveyor/openshift-velero-plugin/velero-plugins/pod/restore.go:333" pluginName=velero-plugins restore=openshift-adp/testnsbackup-1-20240315091156
time="2024-03-15T16:12:52Z" level=info msg="shubham majorVersionInt: 4, minorVersionInt: 14" cmd=/plugins/velero-plugins logSource="/opt/app-root/src/github.com/konveyor/openshift-velero-plugin/velero-plugins/pod/restore.go:340" pluginName=velero-plugins restore=openshift-adp/testnsbackup-1-20240315091156
time="2024-03-15T16:12:52Z" level=info msg="shubham WaitForPullSecrets: true" cmd=/plugins/velero-plugins logSource="/opt/app-root/src/github.com/konveyor/openshift-velero-plugin/velero-plugins/pod/restore.go:215" pluginName=velero-plugins restore=openshift-adp/testnsbackup-1-20240315091156
shubham@fedora ~/oadp-operator - (master) $ oc version
Client Version: 4.14.7
Kustomize Version: v5.0.1
Server Version: 4.14.11
Kubernetes Version: v1.27.10+28ed2d7
Testing on OCP 4.15.z with registry disabled:
shubham@fedora ~/oadp-operator - (master) $ oc logs velero-85c64d7f8c-wnkx6 | grep shubham
Defaulted container "velero" out of: velero, openshift-velero-plugin (init), velero-plugin-for-aws (init), velero-plugin-for-csi (init)
time="2024-03-15T16:15:56Z" level=info msg="shubham imageRegistryEnabled: false" cmd=/plugins/velero-plugins logSource="/opt/app-root/src/github.com/konveyor/openshift-velero-plugin/velero-plugins/pod/restore.go:333" pluginName=velero-plugins restore=openshift-adp/testnsbackup-1-20240315091555
time="2024-03-15T16:15:56Z" level=info msg="shubham majorVersionInt: 4, minorVersionInt: 15" cmd=/plugins/velero-plugins logSource="/opt/app-root/src/github.com/konveyor/openshift-velero-plugin/velero-plugins/pod/restore.go:340" pluginName=velero-plugins restore=openshift-adp/testnsbackup-1-20240315091555
time="2024-03-15T16:15:56Z" level=info msg="shubham WaitForPullSecrets: false" cmd=/plugins/velero-plugins logSource="/opt/app-root/src/github.com/konveyor/openshift-velero-plugin/velero-plugins/pod/restore.go:215" pluginName=velero-plugins restore=openshift-adp/testnsbackup-1-20240315091555
shubham@fedora ~/oadp-operator - (master) $ oc version
Client Version: 4.14.7
Kustomize Version: v5.0.1
Server Version: 4.15.0
Kubernetes Version: v1.28.6+6216ea1
shubham@fedora ~/oadp-operator - (master) $
@shubham-pampattiwar: This pull request references OADP-3598 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
@shubham-pampattiwar: all tests passed!
Full PR test history. Your PR dashboard.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: shubham-pampattiwar, sseago, weshayutin
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/cherry-pick oadp-1.3
@shubham-pampattiwar: once the present PR merges, I will cherry-pick it on top of oadp-1.3 in a new PR and assign it to you.
@shubham-pampattiwar: new pull request created: #237
This PR updates the logic to check whether OpenShift Image Registry is enabled or not.