search

openshift / openshift-velero-plugin

General Velero plugin for backup and restore of openshift workloads.
Apache License 2.0
48 stars 38 forks source link

Build plugin rewrite and buildconfig plugin addition #8

Closed sseago closed 5 years ago

sseago commented 5 years ago

This commit fixes several problems with the build plugin: 1) Don't abandon other (pull/push secret) items if image is external 2) Take into account image refs in several locations, not just SourceStrategy 3) Filter image ref consideration on DockerImage kind 4) Only modify push/pull secret if the corresponding secret is the default builder-dockercfg- secret (and is present). For empty secrets, leave empty, and for custom secrets, leave as-is since those are migrated. 5) Take into account push/pull secrets in all relevant locations, not just SourceStrategy and Output. 6) Apply all of the above to BuildConfig as well

sseago commented 5 years ago

Fixed the test. Forgot that this plugin had a test (most of them don't) -- it's been updated to reflect the changes. Once the CI build passes I'll merge.