search

openshift / origin-aggregated-logging

139 stars 230 forks source link

Remove unmount logic from fluend #1262

Closed jcantrill closed 3 years ago

jcantrill commented 6 years ago

We see a lot of the following in the fluent logs

umount: /var/lib/docker/containers/ec7c381febb53c13dd783940010d562f2aebaadef9f0b55d99d76c1628d9de44/shm: not mounted
umount: /var/lib/docker/containers/ee28ce7ebe4c8c59d12981a44a4d250f00bdfd002c8d0c36a3a9b8ad22f3261c/shm: not mounted
umount: /var/lib/docker/containers/efe0327286e0a47c5068747f8345ad15e718effcaa4106282614268f98d7cb7d/shm: not mounted
umount: /var/lib/docker/containers/f1efa1c4a045265bffa2d183cb27312b747d76f6962b1e09f9bff77d93bcc467/shm: not mounted
umount: /var/lib/docker/containers/f2938245cae1661b4dc46bd149ca1f13f1a9abf2286c4818c5fae35597873a24/shm: not mounted
umount: /var/lib/docker/containers/f307ed2dee303b490b36fdef82fdb10546ceb679c5df7a2c9b859531ded4101b/shm: not mounted
umount: /var/lib/docker/containers/fe70cc01c814827f0e8524994fa35a3f58513ed8e15d4543341316886c99160c/shm: not mounted

This was added because of an issue with pods terminating and either fluent or someother process holding onto file handles which I believe has since been resolved for several releases.

@richm @mrunalp is this something you recall? Can we remove it from the run script in fluentd?

openshift-bot commented 4 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 4 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 3 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot commented 3 years ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/origin-aggregated-logging/issues/1262#issuecomment-715833146): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.