openshift / origin-aggregated-logging

139 stars 230 forks source link

LOG-1297: Removing JKS files #2100

Closed Red-GV closed 3 years ago

Red-GV commented 3 years ago

Completing the loop for https://github.com/openshift/origin-aggregated-logging/pull/2077. Requires https://github.com/openshift/elasticsearch-operator/pull/669.

This PR removes the JKS files that were replaced in the previously mentioned PR.

/cc @blockloop /assign @ewolinetz

Links

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Red-GV To complete the pull request process, please assign alanconway after the PR has been reviewed. You can assign the PR to them by writing /assign @alanconway in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Red-GV commented 3 years ago

/retest

Red-GV commented 3 years ago

/retest

ewolinetz commented 3 years ago

@Red-GV as soon as we branch for 5.1 we can remove the hold on this /hold

ewolinetz commented 3 years ago

/lgtm

ewolinetz commented 3 years ago

/refresh

ewolinetz commented 3 years ago

/test

openshift-ci[bot] commented 3 years ago

@ewolinetz: The /test command needs one or more targets. The following commands are available to trigger jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2100#issuecomment-844464791): >/test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ewolinetz commented 3 years ago

/test all

ewolinetz commented 3 years ago

/retest

ewolinetz commented 3 years ago

/retest

jcantrill commented 3 years ago

/retest

ewolinetz commented 3 years ago

/hold cancel

ewolinetz commented 3 years ago

/lgtm

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, jcantrill, Red-GV

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/master/OWNERS)~~ [ewolinetz,jcantrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment