search

openshift / origin-aggregated-logging

139 stars 230 forks source link

LOG-1280: Add fluentd-plugin-grafana-loki to fluentd image #2112

Closed alanconway closed 3 years ago

alanconway commented 3 years ago

PR has two commits, the first updates the kafka plugin, which had dependency problems. The second adds the loki plugin.

/assign jcantril /cc jcantril

Ref: https://issues.redhat.com/browse/LOG-1280

openshift-ci-robot commented 3 years ago

@alanconway: GitHub didn't allow me to assign the following users: jcantril.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2112): >PR has two commits, the first updates the kafka plugin, which had dependency problems. >The second adds the loki plugin. > >/assign jcantril >/cc jcantril Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
alanconway commented 3 years ago

update script runs smootly make suceeds only one unexpected diff in oj.gemspec - looks harmless. @jcantrill can I get an LGTM?

alanconway commented 3 years ago

/unhold /retest

alanconway commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

@alanconway: you cannot LGTM your own PR.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2112#issuecomment-832753464): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/master/OWNERS)~~ [alanconway,jcantrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.