search

openshift / origin-aggregated-logging

139 stars 230 forks source link

pin msgpack to <1.4.0 #2121

Closed foosinn closed 2 years ago

foosinn commented 3 years ago

1.4.0 is incompatible with used ruby version

Description

Currently build the Dockerimage with Centos7 is broken. This pins the version of msgpack and allows to build it.

/cc @richm /assign @jcantrill

Links

None

openshift-ci[bot] commented 3 years ago

@foosinn: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2121): >pin msgpack to <1.4.0 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 years ago

Hi @foosinn. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: foosinn To complete the pull request process, please assign nhosoi after the PR has been reviewed. You can assign the PR to them by writing /assign @nhosoi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/release-3.11/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jcantrill commented 3 years ago

/ok-to-test

jcantrill commented 3 years ago

@foosinn can you open an issue at issues.redhat.com and ref that issue in this PR

foosinn commented 3 years ago

@jcantrill can you let me know which project that is?

jcantrill commented 3 years ago

OCP/Logging: image

foosinn commented 3 years ago

issues.redhat.com seems to be a Jira that does not contain the Project. Am I missing something?

jcantrill commented 3 years ago

issues.redhat.com seems to be a Jira that does not contain the Project. Am I missing something?

My mistake: https://bugzilla.redhat.com/

jcantrill commented 3 years ago

/retest

openshift-ci[bot] commented 3 years ago

@foosinn: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/images 5218b6777a1c58660fd5f20e898e2b9783e8b8b5 link /test images
ci/openshift-jenkins/json-file 5218b6777a1c58660fd5f20e898e2b9783e8b8b5 link /test json-file
ci/openshift-jenkins/logging 5218b6777a1c58660fd5f20e898e2b9783e8b8b5 link /test logging

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 2 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 2 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 2 years ago

@openshift-bot: Closed this PR.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2121#issuecomment-987272900): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.