search

openshift / origin-aggregated-logging

139 stars 230 forks source link

bug 1946604: update eventrouter submodule to latest master #2123

Closed vparfonov closed 3 years ago

vparfonov commented 3 years ago

Signed-off-by: Vitalii Parfonov vparfono@redhat.com

Description

use safe object casting to avoid panic, see: https://github.com/openshift/eventrouter/pull/19

/cc /assign

/cherry-pick

Links

openshift-ci[bot] commented 3 years ago

@vparfonov: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2123): >bug1946604: update eventrouter submodule to latest master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 years ago

@vparfonov: This pull request references Bugzilla bug 1946604, which is valid.

1 validation(s) were run on this bug * bug target release (4.6.z) matches configured target release for branch (4.6.z)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anli@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2123): >bug 1946604: update eventrouter submodule to latest master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jcantrill commented 3 years ago

/approve /lgtm

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/release-4.6/OWNERS)~~ [jcantrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci[bot] commented 3 years ago

@vparfonov: This pull request references Bugzilla bug 1946604, which is valid.

1 validation(s) were run on this bug * bug target release (4.6.z) matches configured target release for branch (4.6.z)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anli@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2123): >bug 1946604: update eventrouter submodule to latest master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sdodson commented 3 years ago

[patch-manager] :hourglass: This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

We've hit capacity of 50 for this week.

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

jcantrill commented 3 years ago

@sdodson logging is supposed to live by modified set of rules. Logging QE capacity may not be an issue here, please re-consider

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.