openshift / origin-aggregated-logging

139 stars 230 forks source link

Enable MAVEN_REPO_URL for the ingest plugin #2137

Closed lukas-vlcek closed 3 years ago

lukas-vlcek commented 3 years ago

Description

Enabling $MAVEN_REPO_URL for the ES ingest plugin to enable cpass built to succeed.

/cc @vimalk78 /assign @jcantrill

jcantrill commented 3 years ago

/approve

jcantrill commented 3 years ago

/lgtm

jcantrill commented 3 years ago

/cherrypick master

openshift-cherrypick-robot commented 3 years ago

@jcantrill: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2137#issuecomment-870816873): >/cherrypick master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, lukas-vlcek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/release-5.1/OWNERS)~~ [jcantrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 3 years ago

@jcantrill: new pull request created: #2138

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2137#issuecomment-870816873): >/cherrypick master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.