search

openshift / origin-aggregated-logging

139 stars 230 forks source link

vendoring in newer @elastic/lodash and lodash #2139

Closed ewolinetz closed 3 years ago

ewolinetz commented 3 years ago

Description

Updating elasticsearch/lodash and the node_modules/lodash being vendored in

/cc @jcantrill

/cherry-pick release-5.1

Links

ewolinetz commented 3 years ago

/hold to verify no regressions to kibana functionality

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/master/OWNERS)~~ [ewolinetz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ewolinetz commented 3 years ago

this one may not be possible without a full rebuild of kibana...

openshift-ci[bot] commented 3 years ago

@ewolinetz: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/elastic-operator-e2e 0c7c37658cfd3a619e42d6b38c3dea4563e8b512 link /test elastic-operator-e2e
ci/prow/smoke 0c7c37658cfd3a619e42d6b38c3dea4563e8b512 link /test smoke
ci/prow/cluster-logging-operator-e2e 0c7c37658cfd3a619e42d6b38c3dea4563e8b512 link /test cluster-logging-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).