In fluentd-plugin-cloudwatch-logs, added support for passing the ssl_verify_peer flag to the AWS SDK

openshift / origin-aggregated-logging

139 stars 231 forks source link

In fluentd-plugin-cloudwatch-logs, added support for passing the ssl_verify_peer flag to the AWS SDK #2176

Closed syedriko closed 2 years ago

syedriko commented 2 years ago

Description

ssl_verify_peer boolean flag is needed for testing the CloudWatch log forwarder against the moto AWS mock server https://github.com/spulec/moto , which by default runs with a self-signed certificate Not intended for production, so no doc impact.

/cc @jcantrill /assign @igor-karpukhin

Links

PR depending on this one: https://github.com/openshift/cluster-logging-operator/pull/1162
JIRA: https://issues.redhat.com/browse/LOG-1479
Upstream PR: https://github.com/fluent-plugins-nursery/fluent-plugin-cloudwatch-logs/pull/239

syedriko commented 2 years ago

/test smoke

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, syedriko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/master/OWNERS)~~ [jcantrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

syedriko commented 2 years ago

@syedriko please make sure to add a PR against the upstream plugin for this change

It's already there: https://github.com/fluent-plugins-nursery/fluent-plugin-cloudwatch-logs/pull/239

syedriko commented 2 years ago

/test smoke

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.