search

openshift / origin-aggregated-logging

139 stars 231 forks source link

fix: memory detection for ES on cgroupv2 #2182

Closed m-yosefpor closed 2 years ago

m-yosefpor commented 2 years ago

Description

Elasticsearch pods can not start on systems with cgroup v2 enabled, since its hierarchy is different from cgroup v1 and the memory limit file is at /sys/fs/cgroup/memory.max instead of /sys/fs/cgroup/memory/memory.limit_in_bytes.

For full description of the bug see this issue: https://github.com/openshift/origin-aggregated-logging/issues/2181

/cc @lukas-vlcek @jcantrill /assign @jcantrill

/cherry-pick

Links

openshift-ci[bot] commented 2 years ago

Hi @m-yosefpor. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
m-yosefpor commented 2 years ago

/assign @jcantrill

jcantrill commented 2 years ago

/ok-to-test

periklis commented 2 years ago

/retest

periklis commented 2 years ago

/retest

jcantrill commented 2 years ago

/approve /lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, m-yosefpor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/master/OWNERS)~~ [jcantrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.