openshift / origin-aggregated-logging

139 stars 230 forks source link

Log 1870: Removing deprecated map values #2194

Closed Red-GV closed 2 years ago

Red-GV commented 2 years ago

Removes deprecated values from the jaeger file jsons and some formatting. The elasticsearch_deprecation.log now looks like this with the current EO:

[2021-10-21T18:59:15,295][WARN ][o.e.d.r.a.a.i.RestGetIndicesAction] [elasticsearch-cdm-s2haufij-1] [types removal] The parameter include_type_name should be explicitly specified in get indices requests to prepare for 7.0. In 7.0 include_type_name will default to 'false', which means responses will omit the type name in mapping definitions.
[2021-10-21T18:59:20,379][WARN ][o.e.d.r.a.a.i.RestGetIndexTemplateAction] [elasticsearch-cdm-s2haufij-1] [types removal] The parameter include_type_name should be explicitly specified in get template requests to prepare for 7.0. In 7.0 include_type_name will default to 'false', which means responses will omit the type name in mapping definitions.
[2021-10-21T18:59:24,352][WARN ][o.e.d.r.a.a.i.RestPutIndexTemplateAction] [elasticsearch-cdm-s2haufij-1] [types removal] The parameter include_type_name should be explicitly specified in put template requests to prepare for 7.0. In 7.0 include_type_name will default to 'false', and requests are expected to omit the type name in mapping definitions.
[2021-10-21T18:59:24,372][WARN ][o.e.d.c.j.Joda           ] [elasticsearch-cdm-s2haufij-1] 'y' year should be replaced with 'u'. Use 'y' for year-of-era.; 'Z' time zone offset/id fails when parsing 'Z' for Zulu timezone. Consider using 'X'. Prefix your date format with '8' to use the new specifier.
[2021-10-21T18:59:33,825][WARN ][o.e.d.r.a.a.i.RestRolloverIndexAction] [elasticsearch-cdm-s2haufij-1] [types removal] The parameter include_type_name should be explicitly specified in rollover requests to prepare for 7.0. In 7.0 include_type_name will default to 'false', which means requests must omit the type name in mapping definitions.

It should be noted that in ES 7:

The include_type_name parameter in the index creation, index template, and mapping APIs will default to false. Setting the parameter at all will result in a deprecation warning.

/cc @lukas-vlcek /assign @igor-karpukhin

Links

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Red-GV To complete the pull request process, please ask for approval from igor-karpukhin after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

@Red-GV: This pull request references Bugzilla bug 1897627, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2194): >Bug 1897627: Removing deprecated map values Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Red-GV commented 2 years ago

/retest

Red-GV commented 2 years ago

/retest

Red-GV commented 2 years ago

/retest

openshift-ci[bot] commented 2 years ago

@Red-GV: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2194): >Log 1870: Removing deprecated map values Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Red-GV commented 2 years ago

/retest

Red-GV commented 2 years ago

/retest

Red-GV commented 2 years ago

FYI: @pavolloffay

Red-GV commented 2 years ago

/retest

Red-GV commented 2 years ago

/retest

Red-GV commented 2 years ago

/retest

Red-GV commented 2 years ago

/retest

Red-GV commented 2 years ago

/retest

Red-GV commented 2 years ago

/retest

openshift-ci[bot] commented 2 years ago

@Red-GV: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/clo-functional-5-4 c81b79db587552e7da5109f2861989d1f9283afe link true /test clo-functional-5-4
ci/prow/elastic-operator-e2e-5-4 c81b79db587552e7da5109f2861989d1f9283afe link true /test elastic-operator-e2e-5-4
ci/prow/cluster-logging-operator-e2e-5-1 c81b79db587552e7da5109f2861989d1f9283afe link true /test cluster-logging-operator-e2e-5-1
ci/prow/cluster-logging-operator-e2e-5-4 c81b79db587552e7da5109f2861989d1f9283afe link true /test cluster-logging-operator-e2e-5-4
ci/prow/cluster-logging-operator-e2e-5-3 c81b79db587552e7da5109f2861989d1f9283afe link true /test cluster-logging-operator-e2e-5-3

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
Red-GV commented 2 years ago

/hold