openshift / origin-aggregated-logging

139 stars 230 forks source link

[release-4.6] Bug 1996671: call strip() only in case the object has that method #2206

Closed openshift-cherrypick-robot closed 2 years ago

openshift-cherrypick-robot commented 2 years ago

This is an automated cherry-pick of #2198

/assign jcantrill

Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1996671

openshift-ci[bot] commented 2 years ago

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2206): >[release-4.6] [LOG-1555](https://issues.redhat.com/browse/LOG-1555): call strip() only in case the object has that method Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1996671, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug * bug target release (4.6.z) matches configured target release for branch (4.6.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anli@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2206): >[release-4.6] Bug 1996671: call strip() only in case the object has that method Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jcantrill commented 2 years ago

/bugzilla refresh

openshift-ci[bot] commented 2 years ago

@jcantrill: This pull request references Bugzilla bug 1996671, which is valid.

2 validation(s) were run on this bug * bug target release (4.6.z) matches configured target release for branch (4.6.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anli@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2206#issuecomment-970690457): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jcantrill commented 2 years ago

/approve /lgtm

jcantrill commented 2 years ago

/retest

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/release-4.6/OWNERS)~~ [jcantrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jcantrill commented 2 years ago

Blocked by https://github.com/openshift/release/pull/23693

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

petr-muller commented 2 years ago

/retest

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

petr-muller commented 2 years ago

/hold

The issues on b03 that caused previous failures have been fixed, this compilation error does not look like anything related to test-platform.

annobin: src/jemalloc.c: ICE: The size of the global_options structure has changed - please rebuild annobin
annobin: src/jemalloc.c: ICE: Please contact the annobin maintainer with details of this problem
annobin: src/jemalloc.c: Build time size: 0xf00 run time size: 0xf08 (64-bit host)
cc1: error: fail to initialize plugin /usr/lib/gcc/x86_64-redhat-linux/8/plugin/annobin.so 
vparfonov commented 2 years ago

/retest

jcantrill commented 2 years ago

/retest

jcantrill commented 2 years ago

/retest

openshift-ci[bot] commented 2 years ago

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/cluster-logging-operator-e2e 04c04765f383d71831c64a469e180343f94ff13e link true /test cluster-logging-operator-e2e
ci/prow/smoke 04c04765f383d71831c64a469e180343f94ff13e link true /test smoke

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 2 years ago

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1996671. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2206): >[release-4.6] Bug 1996671: call strip() only in case the object has that method Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.