search

openshift / origin-aggregated-logging

139 stars 230 forks source link

[release-4.6] Bug 1996671: call strip() only in case the object has that method #2207

Closed jcantrill closed 2 years ago

jcantrill commented 2 years ago

Description

This PR:

Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1996671

/assign @vparfonov

replaces #2206

openshift-ci[bot] commented 2 years ago

@jcantrill: This pull request references Bugzilla bug 1996671, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug * bug target release (4.6.z) matches configured target release for branch (4.6.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anli@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2207): >[release-4.6] Bug 1996671: call strip() only in case the object has that method Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jcantrill commented 2 years ago

/retest

vparfonov commented 2 years ago

/lgtm

anpingli commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anpingli, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/release-4.6/OWNERS)~~ [jcantrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
anpingli commented 2 years ago

/label cherry-pick-approved

openshift-ci[bot] commented 2 years ago

@jcantrill: All pull requests linked via external trackers have merged:

Bugzilla bug 1996671 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2207): >[release-4.6] Bug 1996671: call strip() only in case the object has that method Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.