search

openshift / origin-aggregated-logging

139 stars 231 forks source link

Log 2022: Updating resourceVersion attribute to a keyword #2224

Closed Red-GV closed 2 years ago

Red-GV commented 2 years ago

Description

This PR is a followup from https://github.com/ViaQ/elasticsearch-templates/pull/130 It updates the data model to have the resourceVersion as a keyword instead of an integer.

/cc @sasagarw /assign @periklis

Links

openshift-ci[bot] commented 2 years ago

@Red-GV: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sasagarw commented 2 years ago

/lgtm

periklis commented 2 years ago

/approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: periklis, Red-GV, sasagarw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/master/OWNERS)~~ [periklis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment