search

openshift / origin-aggregated-logging

139 stars 231 forks source link

Correction to the fix for LOG-1315: place ua-parser-js-1.0.2 under node_modules/ua-parser-js #2228

Closed syedriko closed 2 years ago

syedriko commented 2 years ago

Correction to the fix for LOG-1315 Place ua-parser-js-1.0.2 under node_modules/ua-parser-js

Description

The fix for LOG-1315 placed the updated ua-parser-js-1.0.2 under node_modules/ua-parser, which should have been node_modules/ua-parser-js. /cc @jcantrill /assign @alanconway

Links

jcantrill commented 2 years ago

/approve /lgtm /retest

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, syedriko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/master/OWNERS)~~ [jcantrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
syedriko commented 2 years ago

/test elastic-operator-e2e-5-1 /test elastic-operator-e2e-5-2 /test elastic-operator-e2e-5-3

syedriko commented 2 years ago

/test cluster-logging-operator-e2e-5-1 /test cluster-logging-operator-e2e-5-3

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci[bot] commented 2 years ago

@syedriko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).