search

openshift / origin-aggregated-logging

139 stars 231 forks source link

Bug 2086496: Remove lookaside cache use for ES6 prom-exporter plugin #2251

Closed periklis closed 2 years ago

periklis commented 2 years ago

Description

The PR addresses the remaining lookaside cache use case for the Elasticsearch image in 4.6

/cc @jcantrill /assign @jcantrill

Links

openshift-ci[bot] commented 2 years ago

@periklis: This pull request references Bugzilla bug 2086496, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug * bug target release (4.6.z) matches configured target release for branch (4.6.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anli@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2251): >Bug 2086496: Remove lookaside cache use for ES6 prom-exporter plugin Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jcantrill commented 2 years ago

@periklis I believe you may also need to make this line active https://github.com/openshift/origin-aggregated-logging/blob/8125bf4a56ae6c6ba467179fa8e17a2a80ebc2ee/elasticsearch/ci-env.sh#L5 since now it will come from koji and it will be available like the other instead of via a zip file

jcantrill commented 2 years ago

/retest

openshift-ci[bot] commented 2 years ago

@periklis: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jcantrill commented 2 years ago

/approve /lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/release-4.6/OWNERS)~~ [jcantrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
periklis commented 2 years ago

/label backport-risk-assessed

periklis commented 2 years ago

I am adding label backport-risk-assessed because this change is required to keep 4.6 building as per ART is asked to move all container-first images to the new source container workflow by Jun 3, 2022.

openshift-ci[bot] commented 2 years ago

@periklis: All pull requests linked via external trackers have merged:

Bugzilla bug 2086496 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2251): >Bug 2086496: Remove lookaside cache use for ES6 prom-exporter plugin Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.