search

openshift / origin-aggregated-logging

139 stars 231 forks source link

Bug 2091584: Add Jaeger auth for dependencies index #2255

Closed frzifus closed 2 years ago

frzifus commented 2 years ago

We need it here too, right? See: https://github.com/openshift/origin-aggregated-logging/pull/2254

Description

/cc @jcantrill /assign

/cherry-pick b621a482eedea4bde0cdd6d646de2324e837e19f

Links

openshift-ci[bot] commented 2 years ago

@frzifus: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2255): >Add Jaeger auth for dependencies index Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

Hi @frzifus. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@frzifus: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2255): >Add Jaeger auth for dependencies index Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jcantrill commented 2 years ago

/ok-to-test /approve /lgtm

jcantrill commented 2 years ago

/approve /lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frzifus, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/release-4.6/OWNERS)~~ [jcantrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

@frzifus: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
frzifus commented 2 years ago

whats needed to continue? @jcantrill

jcantrill commented 2 years ago

@frzifus you need to clone the JIRA issue into bugzilla and then link it here and title the PR appropriately

openshift-ci[bot] commented 2 years ago

@frzifus: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2255): >Add Jaeger auth for dependencies index Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@frzifus: This pull request references Bugzilla bug 2091584, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2255): >Bug 2091584: Add Jaeger auth for dependencies index Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
frzifus commented 2 years ago

/bugzilla refresh

openshift-ci[bot] commented 2 years ago

@frzifus: This pull request references Bugzilla bug 2091584, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2255#issuecomment-1141070958): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
frzifus commented 2 years ago

@jcantrill is the target configured by you? When I click on edit, I can't select anything.

Target Milestone: ---
Target Release: ---
openshift-bot commented 2 years ago

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci[bot] commented 2 years ago

@openshift-bot: This pull request references Bugzilla bug 2091584, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2255#issuecomment-1141569041): >/bugzilla refresh > >Recalculating validity in case the underlying Bugzilla bug has changed. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
frzifus commented 2 years ago

@jcantrill could you help?

jcantrill commented 2 years ago

/refresh

jcantrill commented 2 years ago

/bugzilla refresh

openshift-ci[bot] commented 2 years ago

@jcantrill: Bugzilla bug 2091584 is in a bug group that is not in the allowed groups for this repo. Allowed groups for this repo are:

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2255#issuecomment-1142578054): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jcantrill commented 2 years ago

/refresh

openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build logging-curator5-container-v4.6.0-202311250021.p0.gcd23942.assembly.stream for distgit logging-curator5. All builds following this will include this PR.