search

openshift / origin-aggregated-logging

139 stars 231 forks source link

Remove oc deprecated flags from test script #2269

Closed btaani closed 1 year ago

btaani commented 1 year ago

Description

The flags --logtostderr and --log-dir are deprecated in the newest version of the oc command. This PR removes those flags from one of the test scripts. Reference: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/2845-deprecate-klog-specific-flags-in-k8s-components#removed-klog-flags

Links

btaani commented 1 year ago

/retest

btaani commented 1 year ago

/retest-required

xperimental commented 1 year ago

/refresh

xperimental commented 1 year ago

/skip

openshift-ci[bot] commented 1 year ago

@btaani: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/elastic-operator-e2e-5-4 4fc9e2ba8e58f899d3b416dbabfc80b601eec22e link true /test elastic-operator-e2e-5-4
ci/prow/smoke-5-4 4fc9e2ba8e58f899d3b416dbabfc80b601eec22e link true /test smoke-5-4
ci/prow/cluster-logging-operator-e2e-5-4 4fc9e2ba8e58f899d3b416dbabfc80b601eec22e link true /test cluster-logging-operator-e2e-5-4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
xperimental commented 1 year ago

/lgtm

periklis commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: btaani, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/master/OWNERS)~~ [periklis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment