search

openshift / origin-aggregated-logging

139 stars 231 forks source link

NO-JIRA: Fix curator downstream builds with build-isolation #2274

Closed periklis closed 1 month ago

periklis commented 1 month ago

Description

Required to build curator on ubi9/python-39:1-182.1714671018 because it enables python's build-isolation. When enabled curator brew builds fail to find setuptools (previously when disabled we used the one provided by the system)

/cc @jcantrill

openshift-ci-robot commented 1 month ago

@periklis: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/origin-aggregated-logging/pull/2274): >### Description >Required to build curator on `ubi9/python-39:1-182.1714671018` because it enables python's build-isolation. When enabled curator brew builds fail to find `setuptools` (previously when disabled we used the one provided by the system) > >/cc @jcantrill Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin-aggregated-logging). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin-aggregated-logging/blob/master/OWNERS)~~ [periklis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

@periklis: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
btaani commented 1 month ago

/lgtm