search

openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

Bug 1170540 - False success oo-admin-cartridge --recursive/-R in invalid dir #6312

Closed dinhxuanvu closed 8 years ago

dinhxuanvu commented 8 years ago

When a cartridge is installed with recursive option and an invalid directory, the oo-admin-cartridge command fails to report error and falsely succeed.

This commit adds a invalid/empty directory check to the oo-admin-cartridge to stop execution and report the error to the user.

Bug 1170540 Link https://bugzilla.redhat.com/show_bug.cgi?id=1170540

Signed-off-by: Vu Dinh vdinh@redhat.com

dinhxuanvu commented 8 years ago

@tiwillia @Miciah [test]

tiwillia commented 8 years ago

LGTM besides the wording of the new error.

dinhxuanvu commented 8 years ago

@tiwillia All fixed and [test] please.

openshift-bot commented 8 years ago

Evaluated for online test up to df302d139eaf52a264814529b0254648ed76a0e4

tiwillia commented 8 years ago

[merge] please!

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9050/)

openshift-bot commented 8 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6639/) (Image: devenv_5711)

dinhxuanvu commented 8 years ago

@Miciah @tiwillia Some unexpected mongodb error. Can you guys verify it's not related to my code and re-merge it perhaps?

tiwillia commented 8 years ago

Odd, that is the same thing that happened on another PR earlier today. Lets see if it happens again [merge]

openshift-bot commented 8 years ago

Evaluated for online merge up to df302d139eaf52a264814529b0254648ed76a0e4