search

openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

oo-accept-node: check for missing gear directories #6332

Closed thrasher-redhat closed 8 years ago

thrasher-redhat commented 8 years ago

Bug 1281912 BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1281912

There was no check for the situation where a node has a user but is missing the corresponding gear directory. The oo-accept-node script checks for valid file structures, but does not check that each user has a directory. This change will cause oo-accept-node to fail when there are users without matching directories and let the users know that the file is missing.

Error output should look like:

FAIL: user 5661e47b5de94863ba000001 does not have a home directory /var/lib/openshift/5661e47b5de94863ba000001
thrasher-redhat commented 8 years ago

[test]

openshift-bot commented 8 years ago

Evaluated for online test up to ec4c5b47a84d75c9ea1e6bb7eec1c30205adcbb8

thrasher-redhat commented 8 years ago

Looks like theres already a check for this hiding in a different part of oo-accept-node. See https://github.com/openshift/origin-server/blob/master/node-util/sbin/oo-accept-node#L594. Closing.

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9087/)