search

openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

oo-admin-ctl-user: clarify error msg #6338

Closed sallyom closed 8 years ago

sallyom commented 8 years ago

Bug 1168480 Bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1168480 Clarify oo-admin-ctl-user --addgearsize error msg. Removed the backtrace info from the error msg and updated the error msg. Error msg is now more readable for users.

sallyom commented 8 years ago

[test]

sallyom commented 8 years ago

@tiwillia please review this, thanks

tiwillia commented 8 years ago

Sorry for the late reply on this @sallyom

There appears to be extra newlines in the output with this change:

# oo-admin-ctl-user -l admin --addgearsize small,medium

Adding gear size small,medium for user admin... 
ERROR: Size 'small,medium' is not defined. Available gear sizes: small, small.highcpu, medium, large.

Why is there a \n at the beginning of the exception message?

sallyom commented 8 years ago

@tiwillia took out extra newline, thnx :)

tiwillia commented 8 years ago

Hrmm, maybe this has nothing to do with your change then. The new output looks like this:

# oo-admin-ctl-user --addgearsize asdf -l admin

Adding gear size asdf for user admin... ERROR: Size 'asdf' is not defined. Available gear sizes: small, small.highcpu, medium, large.

I can confirm that the newlines are still present after reverting the change. However annoying they may be, this change did not cause them.

Sorry about that. Can you add the newline back in @sallyom ? You had it right the first time.

sallyom commented 8 years ago

@tiwillia , done, np!

tiwillia commented 8 years ago

Thanks!

[merge]

openshift-bot commented 8 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6671/) (Image: devenv_5737)

openshift-bot commented 8 years ago

Evaluated for online merge up to 3327dbdb673981e6ac3295f0bf052a6711375039

openshift-bot commented 8 years ago

Evaluated for online test up to 3327dbdb673981e6ac3295f0bf052a6711375039

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9123/)