search

openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

Bug 1292206 - oo-idler-stats crashes when there is idled gear in the app #6340

Closed dinhxuanvu closed 8 years ago

dinhxuanvu commented 8 years ago

The oo-idler-stats command is currently broken as it crashes with ValueError if there is idled gear in the application.

This issue is due to PR 6324 on origin-server has removed the unwanted empty item ('') on the list which is returned by run() method. However, is_idled() method has not been fixed and still attempts to remove that unwanted item manually from the list which causes ValueError due to the fact that item is no longer existed. This commit removes the unnecessary code that attempts to remove non-exist item from the list in is_idled() method to avoid the ValueError issue.

Bug 1292206 Link https://bugzilla.redhat.com/show_bug.cgi?id=1292206

Signed-off-by: Vu Dinh vdinh@redhat.com

dinhxuanvu commented 8 years ago

[test] related to #6335 and #6324. @tiwillia Please review and merge :D. Thanks!

openshift-bot commented 8 years ago

Evaluated for online test up to 57bea26c4db1041c324b55cb3753e1d4e4043134

tiwillia commented 8 years ago

This LGTM, tested and it appears to resolve the issue.

[merge] assuming tests pass.

openshift-bot commented 8 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6670/) (Image: devenv_5736)

openshift-bot commented 8 years ago

Evaluated for online merge up to 57bea26c4db1041c324b55cb3753e1d4e4043134

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9121/)